This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
[BAHIR-212] Add MQTT Connector for Flink #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lresende @mbalassi @eskabetxe @gyfora Appreciate for your time to review this PR. thanks! |
eskabetxe
suggested changes
Mar 11, 2021
| } | ||
|
|
||
| private boolean connect() throws Exception { | ||
| this.serverUrl = properties.getProperty(MqttConfig.SERVER_URL); |
There was a problem hiding this comment.
why we need to save this values?
count be used directly where needed?
There was a problem hiding this comment.
It's ok to use directly where needed, but this values may be used in multiple places, such as properties.getProperty(MqttConfig.SERVER_URL), so saving them separately can ensure the code is concise.
| Properties mqttProperties = new Properties(); | ||
|
|
||
| // mqtt server url = tcp://<Org_ID>.messaging.internetofthings.ibmcloud.com:1883 | ||
| mqttProperties.setProperty(MqttConfig.SERVER_URL, |
There was a problem hiding this comment.
could we use some docker image instead of a external system?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java library to integrate MQTT protocol and Apache Flink.
Main goal is to be able to read/write data from/to MQTT using the Flink DataStream API.