GH-27919: [CI][C++] Add a nightly job to test offline build #44721
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline |
|
|
|
Revision: 5c7bb69 Submitted crossbow builds: ursacomputing/crossbow @ actions-08280626f5
|
jonkeane
reviewed
Nov 14, 2024
| shm_size: *shm-size | ||
| ulimits: *ulimits | ||
| environment: | ||
| <<: [*common, *ccache, *sccache, *cpp] |
There was a problem hiding this comment.
I will admit that my knowledge is slightly sketchy here, but do we want ccache and sccache here? Is it possible those could contain built artifacts that aren't offline?
github-actions
bot
added
awaiting changes
raulcd
reviewed
Nov 14, 2024
|
@github-actions crossbow submit test-ubuntu-24.04-cpp-bundled-offline |
github-actions
bot
added
awaiting change review
|
Revision: 62d877d Submitted crossbow builds: ursacomputing/crossbow @ actions-5c885d3fff
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If we have a nightly CI job to test offline build, we will be able to notice that offline build support is broken.
What changes are included in this PR?
ARROW_OFFLINEoption that usescpp/thirdparty/download_dependencies.shand disable DNS resolutionubuntu-cpp-bundled-offlineservice that enable theARROW_OFFLINEoptiontest-ubuntu-24.04-cpp-bundled-offlinenightly jobAre these changes tested?
Yes.
Are there any user-facing changes?
No.