Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44563: [C++] Add missing ARROW_IPC dependency to ARROW_COMPUTE #44684

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kou
Copy link
Member

@kou kou commented Nov 8, 2024

Rationale for this change

The compute module uses the IPC module features for option serialization.

What changes are included in this PR?

Enable the IPC module when the compute module is enabled.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Copy link

github-actions bot commented Nov 8, 2024

⚠️ GitHub issue #44563 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Nov 8, 2024

@jleibs Could you try this?

@mapleFU
Copy link
Member

mapleFU commented Nov 11, 2024

Just curious how did parquet support dependency to ARROW_IPC?

@kou
Copy link
Member Author

kou commented Nov 11, 2024

It also uses the same approach:

define_option(ARROW_PARQUET
"Build the Parquet libraries"
OFF
DEPENDS
ARROW_IPC)

@jleibs
Copy link

jleibs commented Nov 11, 2024

This does not fix my issues. I am explicitly setting:

-DARROW_COMPUTE=OFF

so the dependency on ARROW_IPC is irrelevant.

The issue is that function_internal.cc is included in the build even if ARROW_COMPUTE is disabled.

@jleibs
Copy link

jleibs commented Nov 11, 2024

See here:
https://github.com/apache/arrow/blob/95b7181307fe133e8c84a0c0be2856ee15348b8e/cpp/src/arrow/CMakeLists.txt#L719C5-L799

In short, there is a baseline level of compute functionality included regardless of the ARROW_COMPUTE flag,

As far as I can tell ARROW_COMPUTE falg should actually be called something like ARROW_COMPUTE_EXTRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants