Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Release] Support GitHub token in download_rc_binaries.py #44666

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Nov 7, 2024

Rationale for this change

See apache/arrow-adbc#2307. This script is getting rate-limited on GitHub Actions.

What changes are included in this PR?

Pick up GH_TOKEN if it exists.

Are these changes tested?

N/A

Are there any user-facing changes?

N/A

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Nov 7, 2024
@lidavidm lidavidm marked this pull request as ready for review November 7, 2024 06:31
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit df24a82 into apache:main Nov 7, 2024
7 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Nov 7, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Nov 7, 2024
@lidavidm lidavidm deleted the download_rc_artifacts branch November 7, 2024 06:52
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit df24a82.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants