Convert RunEndEncoded field to Parquet #8069
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
vegarsti
force-pushed
the
ree-to-parquet
branch
3 times, most recently
from
ec40c7f to
5a43f13
Compare
This was referenced Aug 10, 2025
vegarsti
force-pushed
the
ree-to-parquet
branch
from
5a43f13 to
4bea341
Compare
vegarsti
commented
Aug 10, 2025
Comment on lines
+225
to
+228
| DataType::RunEndEncoded(_, v) if is_leaf(v.data_type()) => { | ||
| let levels = ArrayLevels::new(parent_ctx, is_nullable, array.clone()); | ||
| Ok(Self::Primitive(levels)) | ||
| } |
There was a problem hiding this comment.
Exactly same as Dictionary above:
arrow-rs/parquet/src/arrow/arrow_writer/levels.rs
Lines 157 to 160 in 04f217b
vegarsti
commented
Aug 10, 2025
| @@ -59,6 +59,28 @@ macro_rules! downcast_dict_op { | |||
| }; | |||
| } | |||
|
|
|||
| macro_rules! downcast_ree_impl { | |||
vegarsti
commented
Aug 10, 2025
| @@ -167,6 +168,7 @@ pub fn can_cast_types(from_type: &DataType, to_type: &DataType) -> bool { | |||
| can_cast_types(from_key.data_type(), to_key.data_type()) && can_cast_types(from_value.data_type(), to_value.data_type()), | |||
| _ => false | |||
| }, | |||
| // TODO: RunEndEncoded here? | |||
vegarsti
force-pushed
the
ree-to-parquet
branch
from
4bea341 to
0931768
Compare
vegarsti
commented
Aug 10, 2025
| ArrowDataType::FixedSizeBinary(_) => out.push(bytes(leaves.next().unwrap())?), | ||
| _ => out.push(col(leaves.next().unwrap())?), | ||
| }, | ||
| ArrowDataType::RunEndEncoded(_run_ends, value_type) => match value_type.data_type() { |
There was a problem hiding this comment.
I've basically copied what Dictionary does. Not sure if correct!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
TODO
What changes are included in this PR?
TODO
Are these changes tested?
TODO
Are there any user-facing changes?
TODO