Support parsing and display pretty for StructType #7469
Merged
+108
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 8, 2025
There was a problem hiding this comment.
Thank you @goldmedal -- this is really nice and very well tested 👍
| @@ -754,11 +834,13 @@ mod test { | |||
| ("Decimal256(-3, 5)", "Error converting -3 into u8 for Decimal256: out of range integral type conversion attempted"), | |||
| ("Decimal128(3, 500)", "Error converting 500 into i8 for Decimal128: out of range integral type conversion attempted"), | |||
| ("Decimal256(3, 500)", "Error converting 500 into i8 for Decimal256: out of range integral type conversion attempted"), | |||
|
|
|||
| ("Struct(f1, Int64)", "Error finding next type, got unexpected ','"), | |||
alamb
changed the title
|
Thank you @goldmedal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I implemented the
datatype_parsefor the struct type. I follow the DuckDB SQL style to parse a struct type.The format is
I also implemented the
Displayfor the struct type. The display result is reversible.What changes are included in this PR?
datatype_parsefor StructTypeDisplayfor StructTypeAre there any user-facing changes?
Now, we can parse a text as a struct type.