Remove dict_id from schema and make it an IPC concern only #7467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6356 #5981 #1206
Rationale for this change
See the above issues. And this is a follow up to #6711 and #6873.
What changes are included in this PR?
Removal of
dict_id
from the canonicalSchema
'sField
and the resulting repercussions of that.Are there any user-facing changes?
Yes, the previously declared deprecations and a few more resulting changes that we didn't foresee previously.
The ones we did not previously foresee involve those places where we now need to pipe through an IPC schema where we previously only had the regular Schema (which used to be enough since that carried the
dict_id
):flight_data_to_arrow_batch
(arrow-flight)arrow_data_from_flight_data
(arrow-flight; sql)read_record_batch
(arrow-ipc)read_dictionary
(arrow-ipc)FileDecoder::new
(arrow-ipc)I think these don't have stability guarantees but for the sake of completeness:
field_to_json
(arrow-integration-test)record_batch_from_json
(arrow-integration-test)array_from_json
(arrow-integration-test)dictionary_array_from_json
(arrow-integration-test)@tustvold @alamb @thinkharderdev