Skip to content

Improve documentation for AsyncFileReader::get_metadata #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 3, 2025

Which issue does this PR close?

Rationale for this change

While reviewing #7369 and the changes from @corwinjoy in #7342 I found that the documentation could be improved

What changes are included in this PR?

Update the documenatation

Are there any user-facing changes?

Only docs, no code changes

@github-actions github-actions bot added the parquet Changes to the parquet crate label Apr 3, 2025
@alamb alamb added the documentation Improvements or additions to documentation label Apr 3, 2025
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alamb, this is indeed improved.

@corwinjoy
Copy link
Contributor

@alamb Thanks for improving these docs!

@alamb alamb merged commit 5e6c19a into apache:main Apr 4, 2025
16 checks passed
@alamb alamb changed the title Improve documentation for AsyncFileReader::get_metadata Improve documentation for AsyncFileReader::get_metadata Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants