bench: add more {boolean, string, int} benchmarks for concat kernel #7376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
commented
Apr 2, 2025
Comment on lines
-82
to
-87
| let v1 = create_string_array::<i32>(1024, 0.5); | ||
| let v2 = create_string_array::<i32>(1024, 0.5); | ||
| c.bench_function("concat str nulls 1024", |b| { | ||
| b.iter(|| bench_concat(&v1, &v2)) | ||
| }); | ||
|
|
There was a problem hiding this comment.
This was a duplicate benchmark
rluvaton
added a commit
to rluvaton/arrow-rs
that referenced
this pull request
Apr 2, 2025
rluvaton
changed the title
alamb
pushed a commit
that referenced
this pull request
Apr 6, 2025
…uilder implementations (#7309) * feat: add `append_buffer` for `NullBufferBuilder` * feat: add `append_array` for `PrimitiveBuilder` * feat: add `append_array` for `BooleanBuilder` * test: add test that the underlying null values are added as is * wip * format and lint * add special implementation for concat primitives and booleans improving perf by 50% * add more tests for generic bytes builder * add special implementation for bytes in concat * manually concat primitives * add large array impl * wip * remove unsafe API and use primitive builder in concat * lint and format * fix concat primitives to use the input array data type * format * add back the capacity for binary because dictionary call concat_fallback * add tests and update comment * extract benchmark changes to different PR #7376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Requested by @alamb in:
concatperformance, and addappend_arrayfor some array builder implementations #7309 (comment)What changes are included in this PR?
concatperformance, and addappend_arrayfor some array builder implementations #7309 for concatenating a lot of arraysAre there any user-facing changes?
Nope