Skip to content

chore: upgrade flatbuffer version to 25.2.10 #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

tisonkun
Copy link
Member

Reduce the old "bitflags v1.3.2" dep in tree.

It should not have incompatible changes; just Google's version strategy seems to be YY.[M]M.[D]D

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 14, 2025
@alamb
Copy link
Contributor

alamb commented Feb 14, 2025

Thanks @tisonkun !

Maybe this is related to

I think since flatbuffers is directly used in the arrow-ipc structures, this would actually result in a incompatible update (so we have to wait for the next major release)

It should not have incompatible changes; just Google's version strategy seems to be YY.[M]M.[D]D

I think from Rust's perspective these two versions would be incompatible (and thus the rust compiler would complain if they were mixed)

We just hit something like this while trying to upgrade rand:

@alamb alamb added the next-major-release the PR has API changes and it waiting on the next major version label Feb 14, 2025
@alamb alamb changed the title chore: upgrade flatbuffer version chore: upgrade flatbuffer version to 25.2.10 Feb 14, 2025
@tisonkun
Copy link
Member Author

@alamb You're right. I'm the dependabot this time 🤣

Thanks for your triage.

@alamb
Copy link
Contributor

alamb commented Mar 24, 2025

I merged up from main to run all the tests again and plan to merge this PR when CI has passed

Thanks for your patience @tisonkun

@alamb alamb merged commit f9a569d into apache:main Mar 25, 2025
27 checks passed
@alamb
Copy link
Contributor

alamb commented Mar 25, 2025

🚀

@alamb alamb added the api-change Changes to the arrow API label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate next-major-release the PR has API changes and it waiting on the next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants