Skip to content

[object_store] Support MD5 checksum in attributes #6915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tzembo
Copy link

@tzembo tzembo commented Dec 26, 2024

Which issue does this PR close?

Closes apache/arrow-rs-object-store#280

Rationale for this change

I would like AWS, Azure, and GCP to validate the data integrity of my uploaded objects. All three providers allow doing so by providing a Content-MD5 header with a 128-bit base64-encoded digest.

What changes are included in this PR?

See apache/arrow-rs-object-store#280

Are there any user-facing changes?

There's an additional Checksum attribute that can be set on requests.

@github-actions github-actions bot added the object-store Object Store Interface label Dec 26, 2024
@Jefffrey
Copy link
Contributor

Jefffrey commented Jan 4, 2025

Looks like there are a few CI errors that'll need to be fixed

@alamb alamb marked this pull request as draft January 10, 2025 19:58
@alamb
Copy link
Contributor

alamb commented Jan 10, 2025

Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look

@alamb
Copy link
Contributor

alamb commented Mar 20, 2025

Thank you for this PR. We are in the process of moving the object_store code to its own repository. Would it be possible for you to create a PR in that repository instead?

(we will handle moving all existing issues to the new repository)

@tzembo
Copy link
Author

tzembo commented Mar 20, 2025

Absolutely - sorry for putting this up and then leaving it unattended, haven't had much bandwidth to get back to it recently. I will put something new together in the new repo 👍

@tzembo tzembo closed this Mar 20, 2025
@alamb
Copy link
Contributor

alamb commented Mar 20, 2025

Absolutely - sorry for putting this up and then leaving it unattended, haven't had much bandwidth to get back to it recently. I will put something new together in the new repo 👍

No worries !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[object_store] Support adding MD5 checksum headers to validate object integrity
3 participants