Export object_store integration tests #5709
Conversation
tustvold
force-pushed
the
export-object-store-integration-tests
branch
from
d7b731e to
cf45dd0
Compare
| } | ||
|
|
||
| #[cfg(any(feature = "azure", feature = "aws"))] | ||
| pub(crate) async fn signing<T>(integration: &T) | ||
| pub async fn signing<T>(integration: &T) |
There was a problem hiding this comment.
I opted to leave signing and tagging behind as they're relatively niche, and created some funky feature flag/dependency shenanigans.
| @@ -25,15 +25,9 @@ use url::Url; | |||
|
|
|||
| #[derive(Debug, Snafu)] | |||
| enum Error { | |||
| #[snafu(display("Unable to convert URL \"{}\" to filesystem path", url))] | |||
There was a problem hiding this comment.
Unrelated clippy lint fix
There was a problem hiding this comment.
is this an API change (as the type enums have changed?)
There was a problem hiding this comment.
These enumerations are module private
There was a problem hiding this comment.
I double checked that this is not visible https://docs.rs/object_store/latest/object_store/path/enum.Error.html?search=InvalidUrl
|
Looks like a new clippy is better at finding unused code, so rolled that into this PR |
There was a problem hiding this comment.
Thank you @tustvold
I think we should:
- Document the new feature flag (along with an example of how to run the integration tests -- I didn't see this anywhere but may have missed it) Perhaps add to docs here
- Figure out if this is an API change or not, and if it is an API change split those out from the extraction to a new feature flag (to allow finer grained control of when breaking changes are needed)
This is a really neat PR BTW
| @@ -70,21 +70,9 @@ enum Error { | |||
| #[snafu(display("Configuration key: '{}' is not known.", key))] | |||
| UnknownConfigurationKey { key: String }, | |||
|
|
|||
| #[snafu(display("Bucket '{}' not found", bucket))] | |||
| BucketNotFound { bucket: String }, | |||
There was a problem hiding this comment.
double checked it is not exposed: https://docs.rs/object_store/latest/object_store/path/enum.Error.html?search=BucketNotFound
Which issue does this PR close?
Closes #5685.
Rationale for this change
The object_store crate has quite a comprehensive test suite, to better enable third-party implementations we can export this for external consumption.
I debated making this a separate crate, but I felt a feature flag was more discoverable, and avoids all the complexities associated with needing to create a separate object_store workspace to contain both crates, and then release both in sync.
What changes are included in this PR?
Are there any user-facing changes?
No