Skip to content

fix: Handle sliced array in run array iterator #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2023
Merged

fix: Handle sliced array in run array iterator #3681

merged 3 commits into from
Feb 13, 2023

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Feb 9, 2023

Which issue does this PR close?

Rationale for this change

The users might want to iterate on sliced run array.

What changes are included in this PR?

The current version of run array iterator run_iterator.rs does not work for sliced array. This PR makes run array iterator work for sliced array.

Are there any user-facing changes?

Run encoded arrays are still under development and most likely not yet used. So, changes to its api should not have any impact.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 9, 2023
@askoa askoa marked this pull request as ready for review February 10, 2023 14:59
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit

@tustvold tustvold merged commit 5ffc0a8 into apache:master Feb 13, 2023
@ursabot
Copy link

ursabot commented Feb 13, 2023

Benchmark runs are scheduled for baseline = d011e6a and contender = 5ffc0a8. 5ffc0a8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants