Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-proxy): remove model options' stream default value #12013

Merged

Conversation

shreemaan-abhishek
Copy link
Contributor

@shreemaan-abhishek shreemaan-abhishek commented Mar 1, 2025

Description

Passing stream option in request body has no effect as it is overridden by default value in the schema. If I want to support stream mode, I need specify stream option in plugin configuration explicitly, which is a bad UX.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working plugin labels Mar 1, 2025
@shreemaan-abhishek shreemaan-abhishek merged commit 4ba442b into apache:master Mar 3, 2025
33 of 34 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the fix-ai-proxy-stream branch March 3, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants