-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(discovery): when endpoint_slices
updated, old endpoints all flush_all/flush_expired
#11577
base: master
Are you sure you want to change the base?
fix(discovery): when endpoint_slices
updated, old endpoints all flush_all/flush_expired
#11577
Conversation
Signed-off-by: dongjiang1989 <[email protected]>
endpoint_slices
updated, old endpoints all flush_all/flush_expired
endpoint_slices
updated, old endpoints all flush_all/flush_expiredendpoint_slices
updated, old endpoints all flush_all/flush_expired
Signed-off-by: dongjiang1989 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add test cases and explain the changes in detail and how it solves the issue.
Thanks @shreemaan-abhishek . |
/ok-to-test |
please add test cases |
/ok-to-test |
Thanks @shreemaan-abhishek . |
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Description
Fixes # (endpoint muti slices)
Bad case:
If the number of nodes of a certain service is too large, for example, it is split into two endpoint slices:
slice1: There are
pod1
andpod2
.slice2: There are
pod3
andpod4
.If the pod is re-scheduled and only slice1 or slice2 is updated, the upstream will only be updated to
pod1
+pod2
orpod3
+pod4
.When
watch_endpoint_slices_schema
is true(endpoint_slice model), removeinformer.pre_list
andinformer.post_list
Checklist