Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using static modifier to normalize methods contract and performance #198

Closed
wants to merge 1 commit into from
Closed

Conversation

tbw777
Copy link

@tbw777 tbw777 commented Feb 2, 2023

No description provided.

@bodewig
Copy link
Member

bodewig commented Feb 8, 2023

I must say I find it extremely difficult to properly review a PR that touches 100+ files, even if the change is supposed to be mechanical.

In this case I saw a change to Antlib.java where a string literal was replaced by a constant defined somewhere else in the class - a place that is not visible inside the diff so I need to look up its definition elsewhere. This not only makes the review more difficult it also means I can not just scroll down the page and press merge as the set of changes obviously also contains changes not described by the headline.

All in all I don't see myself being able to review this in any reasonable time frame. If you want to see this applied, please cut it into smaller chunks.

@tbw777 tbw777 closed this by deleting the head repository Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants