Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3410] cancel renew procedure after releasing block #3421

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Aireed
Copy link
Contributor

@Aireed Aireed commented Jan 23, 2025

Why are the changes needed?

Close #3410 .

Brief change log

  • when we release block, we should cancel the renew future.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 21.58%. Comparing base (63aab48) to head (4e21a65).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../amoro/table/blocker/BasicTableBlockerManager.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3421      +/-   ##
============================================
- Coverage     21.59%   21.58%   -0.01%     
  Complexity     2353     2353              
============================================
  Files           431      431              
  Lines         40347    40355       +8     
  Branches       5711     5713       +2     
============================================
- Hits           8712     8710       -2     
- Misses        30903    30912       +9     
- Partials        732      733       +1     
Flag Coverage Δ
trino 21.58% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution!

@Aireed Aireed merged commit 9bfe609 into apache:master Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: need call cancelRenew when release a Renewableblocker
3 participants