Skip to content

Commit

Permalink
[iceberg-1.6.0]: remove IcebergRewriteExecutor with 1.5+
Browse files Browse the repository at this point in the history
  • Loading branch information
ConradJam committed Jul 30, 2024
1 parent fd181b5 commit 85e54e1
Showing 1 changed file with 0 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.apache.amoro.table.MixedTable;
import org.apache.amoro.utils.map.StructLikeCollections;
import org.apache.iceberg.PartitionSpec;
import org.apache.iceberg.StructLike;
import org.apache.iceberg.TableProperties;
import org.apache.iceberg.data.GenericAppenderFactory;
import org.apache.iceberg.data.IdentityPartitionConverters;
Expand All @@ -46,18 +45,6 @@ public IcebergRewriteExecutor(
super(input, table, structLikeCollections);
}

// TODO We can remove this override method after upgrading Iceberg version to 1.5+.
@Override
protected StructLike partition() {
StructLike partitionData = super.partition();
if (partitionData != null && partitionData.size() == 0) {
// Cast empty partition data to NULL to avoid creating empty partition directory.
return null;
} else {
return partitionData;
}
}

@Override
protected OptimizingDataReader dataReader() {
return new GenericCombinedIcebergDataReader(
Expand Down

0 comments on commit 85e54e1

Please sign in to comment.