Skip to content

Commit

Permalink
[Improvement]: Increase the default database connection pool max wait…
Browse files Browse the repository at this point in the history
… time (#3419)
  • Loading branch information
Marvel-Gu committed Jan 24, 2025
1 parent 49989ba commit 599aeb5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ public class AmoroManagementConf {
public static final ConfigOption<Long> DB_CONNECT_MAX_WAIT_MILLIS =
ConfigOptions.key("database.connection-pool-max-wait-millis")
.longType()
.defaultValue(1000L)
.defaultValue(30000L)
.withDescription("Max wait time before getting a connection timeout.");

public static final ConfigOption<Long> OPTIMIZER_HB_TIMEOUT =
Expand Down
2 changes: 1 addition & 1 deletion charts/amoro/templates/amoro-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ data:
url: {{ .Values.amoroConf.database.url }}
connection-pool-max-total: 20
connection-pool-max-idle: 16
connection-pool-max-wait-millis: 1000
connection-pool-max-wait-millis: 30000
terminal:
backend: {{ .Values.amoroConf.terminal.backend }}
Expand Down
6 changes: 3 additions & 3 deletions dist/src/main/amoro-bin/conf/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ ams:
url: jdbc:derby:/tmp/amoro/derby;create=true
connection-pool-max-total: 20
connection-pool-max-idle: 16
connection-pool-max-wait-millis: 1000
connection-pool-max-wait-millis: 30000

# MySQL database configuration.
# database:
Expand All @@ -112,7 +112,7 @@ ams:
# auto-create-tables: true
# connection-pool-max-total: 20
# connection-pool-max-idle: 16
# connection-pool-max-wait-millis: 1000
# connection-pool-max-wait-millis: 30000

# Postgres database configuration.
# database:
Expand All @@ -124,7 +124,7 @@ ams:
# auto-create-tables: true
# connection-pool-max-total: 20
# connection-pool-max-idle: 16
# connection-pool-max-wait-millis: 1000
# connection-pool-max-wait-millis: 30000

terminal:
backend: local
Expand Down

0 comments on commit 599aeb5

Please sign in to comment.