Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Variable API #45265

Merged
merged 8 commits into from
Dec 29, 2024
Merged

Import Variable API #45265

merged 8 commits into from
Dec 29, 2024

Conversation

shubhamraj-git
Copy link
Contributor

@shubhamraj-git shubhamraj-git commented Dec 29, 2024

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 29, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Good to add it to public API (even though I assume you only do this for the UI feature :-D)

Small nit, I assume you need to re-run pre-commit locally once to fix the Fast API API specs.

@shubhamraj-git
Copy link
Contributor Author

@jscheffl

Yaa, In starting I thought to add this as private endpoint for UI.
But we have a option to do it from CLI.
So, thought to be consistent and add public API.

Also, regarding the static checks, I tried running it locally. It suggesting me to change the name of ImportVariableBody to Body_import_variables, Not sure, why there is constraint to change it.

@jscheffl jscheffl merged commit 11cdd97 into apache:main Dec 29, 2024
49 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* add the api

* tests

* ImportVariablesBody

* action_if_exists

* rename

* add desc

* fix

* remove unwanted teardown
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 6, 2025
* add the api

* tests

* ImportVariablesBody

* action_if_exists

* rename

* add desc

* fix

* remove unwanted teardown
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
* add the api

* tests

* ImportVariablesBody

* action_if_exists

* rename

* add desc

* fix

* remove unwanted teardown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants