Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full screen view for logs #45183

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tirkarthi
Copy link
Contributor

Related #44663 (comment)

It will be useful to have logs open in full screen view to read the logs. Currently the tab and task details are still present on scroll taking more space. Legacy logs page had more screen space which was useful for our users internally. The implementation is simple that uses dialog to display the same code block with wrap and other styles applied in full screen mode.

Notes for reviewer and self :

  • I would opt for removing Dialog.Header section too to get more space or replace log with some other useful information.
  • Using an IconButton but can change to button with text "Full Screen" for uniformity.

image

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 23, 2024

<Dialog.CloseTrigger />

<Dialog.Body>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the try selector and wrap/unwrap button in the modal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I suppose the entire content from can become a component like <LogComponent> and then show FullScreen based on the present inside the dialog or not like below. Are there any other ways to do this idiomatic in react without a separate component?

<Box>
    <LogComponent showFullScreenButton />
    <Dialog>
        <LogComponent />
    </Dialog>
</Box>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried copy pasting code to try this out. IMO it still takes up some space with tries, I would prefer selecting the log and then clicking on the fullscreen to utilise the screen space fully.

Full screen with task tries and wrap

image

Fullscreen without dialog header

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants