Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: K8S 1.32 support #45149

Merged
merged 2 commits into from
Dec 23, 2024
Merged

feat: K8S 1.32 support #45149

merged 2 commits into from
Dec 23, 2024

Conversation

raphaelauv
Copy link
Contributor

No description provided.

@raphaelauv raphaelauv force-pushed the feat/K8S_132_support branch 3 times, most recently from d2a9721 to 48a992e Compare December 22, 2024 15:47
@raphaelauv
Copy link
Contributor Author

I can't reproduce with pre-commit run --all-files the error of the CI Update breeze docs

@potiuk
Copy link
Member

potiuk commented Dec 22, 2024

Rebase. It's already been fixed in main in #45156 - that was instability in sequence of options in click config dictionary in click 8.1.8 which caused random hash calculation.

@raphaelauv
Copy link
Contributor Author

Thanks for your help , I rebased and it still failing, any idea ?

@potiuk
Copy link
Member

potiuk commented Dec 22, 2024

Yeah. You need to run breeze static-checks --last-commit and it should fix itself.

@potiuk
Copy link
Member

potiuk commented Dec 22, 2024

(or so I think)

@raphaelauv
Copy link
Contributor Author

yes I tried breeze static-checks --last-commit after the rebase , no effect

@potiuk potiuk force-pushed the feat/K8S_132_support branch from 5b51aea to d4bd767 Compare December 23, 2024 12:39
@potiuk
Copy link
Member

potiuk commented Dec 23, 2024

Try breeze ci-image build --python 3.9 and repeat it.

@raphaelauv
Copy link
Contributor Author

yes I already tried to rebuild my breeze context , no effect

@potiuk
Copy link
Member

potiuk commented Dec 23, 2024

You can also (though it should happen automatically) remove and re-install breeze uv tool remove airflow_breeze followed by uv tool install --editable ./dev/breeze. Maybe also you did the rebuild before constraints were updated - then breeze ci-image build --upgrade-to-newer-dependencies might help.

@potiuk
Copy link
Member

potiuk commented Dec 23, 2024

I re-run it locally and those hashes were properly calculated - I pushed a fixup.

@raphaelauv
Copy link
Contributor Author

breeze ci-image build --upgrade-to-newer-dependencies fixed it 👍

thanks

@potiuk
Copy link
Member

potiuk commented Dec 23, 2024

breeze ci-image build --upgrade-to-newer-dependencies fixed it 👍

thanks

Ah. I found out the root cause - we should also upgrade minimum version of click in "airflow" so that breeze ci-image build will upgrade it as well - I missed that in #45156.

This should be fixed now for everyone else via: #45177

@potiuk potiuk merged commit 545bb84 into apache:main Dec 23, 2024
91 checks passed
@raphaelauv raphaelauv deleted the feat/K8S_132_support branch December 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants