WIP: [Resolve OOM When Reading Large Logs in Webserver] Refactor to Use K-Way Merge for Log Streams Instead of Sorting Entire Log Records #45129
+819
−374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
refactor/webserver-oom-for-large-log-read
branch
from
ed334f7 to
1d0e6ed
Compare
|
Rebased after we fixed main issue |
jason810496
force-pushed
the
refactor/webserver-oom-for-large-log-read
branch
from
1d0e6ed to
8617e5b
Compare
17 tasks
jason810496
force-pushed
the
refactor/webserver-oom-for-large-log-read
branch
from
0f19a8b to
ef3450b
Compare
|
CI is failing due to: Since the |
potiuk
added
legacy ui
|
Applied and closed/reopened to trigger the build |
- refactor _read and read methods in FileTaskHandler - refactor read_log_chunks method in TaskLogReader
- add check log_stream type utils
- fix type checking for
- test_file_task_handler_when_ti_value_is_invalid
- test_file_task_handler
- test_file_task_handler_running
- test_file_task_handler_rotate_size_limit
- test__read_when_local
- test__read_served_logs_checked_when_done_and_no_local_or_remote_logs
- also test compatible interface for test__read_served_logs_checked_when_done_and_no_local_or_remote_logs
- which might call _read_remote_logs
- Since read_log_chunks is public method, refactor it as same return type in orignial implementation to avoid breaking change - The `host` should only show once in read_log_stream
- Fix mock_read to new stream-based reading in test_log_reader - Fix test for expecting stdout of callable should be in log lines
- Logs might not be add to heap in first round, should consider log_streams instead of heap
- Make it compatible for providers that implemented _read method.
jason810496
force-pushed
the
refactor/webserver-oom-for-large-log-read
branch
from
ef3450b to
0aaf0ab
Compare
|
Fix the provider tests that explicitly use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #45079
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.