-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add view_url for DagBundles #45126
Open
ephraimbuddy
wants to merge
3
commits into
apache:main
Choose a base branch
from
astronomer:bundle_view_url
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add view_url for DagBundles #45126
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ | |
|
||
import tempfile | ||
from pathlib import Path | ||
from unittest import mock | ||
|
||
import pytest | ||
from git import Repo | ||
|
@@ -265,3 +266,33 @@ def test_subdir(self, git_repo): | |
files_in_repo = {f.name for f in bundle.path.iterdir() if f.is_file()} | ||
assert str(bundle.path).endswith(subdir) | ||
assert {"some_new_file.py"} == files_in_repo | ||
|
||
@pytest.mark.parametrize( | ||
"repo_url, expected_url", | ||
[ | ||
("[email protected]:apache/airflow.git", "https://github.com/apache/airflow/tree/0f0f0f"), | ||
("[email protected]:apache/airflow.git", "https://gitlab.com/apache/airflow/-/tree/0f0f0f"), | ||
("[email protected]:apache/airflow.git", "https://bitbucket.org/apache/airflow/src/0f0f0f"), | ||
], | ||
) | ||
@mock.patch("airflow.dag_processing.bundles.git.Repo") | ||
def test_view_url(self, mock_gitrepo, repo_url, expected_url): | ||
bundle = GitDagBundle( | ||
name="test", | ||
refresh_interval=300, | ||
repo_url=repo_url, | ||
tracking_ref="main", | ||
) | ||
view_url = bundle.view_url("0f0f0f") | ||
assert view_url == expected_url | ||
|
||
@mock.patch("airflow.dag_processing.bundles.git.Repo") | ||
def test_view_url_returns_none_when_no_version_in_view_url(self, mock_gitrepo): | ||
bundle = GitDagBundle( | ||
name="test", | ||
refresh_interval=300, | ||
repo_url="[email protected]:apache/airflow.git", | ||
tracking_ref="main", | ||
) | ||
view_url = bundle.view_url(None) | ||
assert view_url is None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High