-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Asset.ref for name or URI references #45028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ephraimbuddy,
pierrejeambrun,
potiuk,
jedcunningham,
ashb,
bolkedebruin and
XD-DENG
as code owners
December 18, 2024 12:03
boring-cyborg
bot
added
area:API
Airflow's REST/HTTP API
area:db-migrations
PRs with DB migration
area:Scheduler
including HA (high availability) scheduler
area:serialization
area:task-sdk
kind:documentation
labels
Dec 18, 2024
uranusjr
added
AIP-75
Asset-Centric Syntax
and removed
area:Scheduler
including HA (high availability) scheduler
area:serialization
area:API
Airflow's REST/HTTP API
kind:documentation
area:db-migrations
PRs with DB migration
area:task-sdk
labels
Dec 18, 2024
uranusjr
force-pushed
the
asset-schedule
branch
from
December 18, 2024 12:12
dab6e39
to
bb527de
Compare
uranusjr
force-pushed
the
asset-schedule
branch
from
December 18, 2024 12:28
bb527de
to
5cd6c5d
Compare
uranusjr
added
area:Scheduler
including HA (high availability) scheduler
area:serialization
area:API
Airflow's REST/HTTP API
kind:documentation
area:task-sdk
labels
Dec 18, 2024
uranusjr
force-pushed
the
asset-schedule
branch
from
December 18, 2024 12:47
5cd6c5d
to
e6b3d71
Compare
uranusjr
force-pushed
the
asset-schedule
branch
2 times, most recently
from
December 18, 2024 13:56
1876468
to
15cffbc
Compare
uranusjr
force-pushed
the
asset-schedule
branch
2 times, most recently
from
December 24, 2024 08:21
6e82d46
to
f78ec93
Compare
Lee-W
reviewed
Dec 25, 2024
Lee-W
approved these changes
Dec 25, 2024
This allows us to refer to an asset without needing the original object, making it easier to schedule against an asset.
uranusjr
force-pushed
the
asset-schedule
branch
from
December 26, 2024 02:35
7db4a40
to
fa1adcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
AIP-75
Asset-Centric Syntax
area:API
Airflow's REST/HTTP API
area:Scheduler
including HA (high availability) scheduler
area:serialization
area:task-sdk
kind:documentation
legacy api
Whether legacy API changes should be allowed in PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to refer to an asset without needing the original object, making it easier to schedule against an asset.
I also added some minor improvements to
register_asset_change
so we can save a db query or the asset-model conversion in some cases.There are a couple of possible sytax designs available:
I’m opting for the second one with a factory method since it is easier to implement, but we can discuss which one we like better.