Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow json_result_force_utf8_encoding specification in providers.snowflake.hooks.SnowflakeHook extra dict #44264

Conversation

ttzhou
Copy link
Contributor

@ttzhou ttzhou commented Nov 21, 2024

Motivation/Justification:

Snowflake's Python connector recommends using json_result_force_utf8_decoding to True, but preserves it as False/no-op for legacy reasons. I've come across cases at work where not setting this returns unexpected results, whereas setting it to True (via a workaround) returns the expected results.

Therefore, I think there is a valid case for allowing this to be passed via connection arguments (via extra).

Relevant 'upstream' Snowflake connector code


  • Read the Pull Request Guidelines for more information.
    In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
    In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
    In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Nov 21, 2024
Copy link

boring-cyborg bot commented Nov 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@ttzhou ttzhou marked this pull request as ready for review November 21, 2024 18:33
@potiuk potiuk merged commit 518d394 into apache:main Nov 28, 2024
64 checks passed
Copy link

boring-cyborg bot commented Nov 28, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Nov 28, 2024
…nowflake.hooks.SnowflakeHook` extra dict (apache#44264)

* Allow json_result_force_utf8_encoding specification in SnowflakeHook extra dict

* Use a set for the not in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:snowflake Issues related to Snowflake provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants