Skip to content

Commit

Permalink
[AIRFLOW-5246] Remove unused source constructor parameter in BaseHook
Browse files Browse the repository at this point in the history
  • Loading branch information
potiuk committed Aug 18, 2019
1 parent 513d10f commit 053f522
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion airflow/contrib/hooks/cloudant_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class CloudantHook(BaseHook):
"""

def __init__(self, cloudant_conn_id='cloudant_default'):
super().__init__(cloudant_conn_id)
self.cloudant_conn_id = cloudant_conn_id

def get_conn(self):
Expand Down
1 change: 0 additions & 1 deletion airflow/contrib/hooks/gcp_sql_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,6 @@ def __init__(
gcp_conn_id: str = 'google_cloud_default',
default_gcp_project_id: str = None
) -> None:
super().__init__(source=None)
self.gcp_conn_id = gcp_conn_id
self.gcp_cloudsql_conn_id = gcp_cloudsql_conn_id
self.cloudsql_connection = self.get_connection(self.gcp_cloudsql_conn_id)
Expand Down
1 change: 0 additions & 1 deletion airflow/contrib/hooks/imap_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ class ImapHook(BaseHook):
"""

def __init__(self, imap_conn_id='imap_default'):
super().__init__(imap_conn_id)
self.imap_conn_id = imap_conn_id
self.mail_client = None

Expand Down
1 change: 0 additions & 1 deletion airflow/contrib/hooks/jira_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class JiraHook(BaseHook):
def __init__(self,
jira_conn_id='jira_default',
proxies=None):
super().__init__(jira_conn_id)
self.jira_conn_id = jira_conn_id
self.proxies = proxies
self.client = None
Expand Down
1 change: 0 additions & 1 deletion airflow/contrib/hooks/mongo_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ class MongoHook(BaseHook):
conn_type = 'mongo'

def __init__(self, conn_id='mongo_default', *args, **kwargs):
super().__init__(source='mongo')

self.mongo_conn_id = conn_id
self.connection = self.get_connection(conn_id)
Expand Down
1 change: 0 additions & 1 deletion airflow/contrib/hooks/ssh_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ def __init__(self,
timeout=10,
keepalive_interval=30
):
super().__init__(ssh_conn_id)
self.ssh_conn_id = ssh_conn_id
self.remote_host = remote_host
self.username = username
Expand Down
1 change: 0 additions & 1 deletion airflow/contrib/hooks/winrm_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def __init__(self,
message_encryption='auto',
credssp_disable_tlsv1_2=False,
send_cbt=True):
super().__init__(ssh_conn_id)
self.ssh_conn_id = ssh_conn_id
self.endpoint = endpoint
self.remote_host = remote_host
Expand Down
2 changes: 0 additions & 2 deletions airflow/hooks/base_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ class BaseHook(LoggingMixin):
instances of these systems, and expose consistent methods to interact
with them.
"""
def __init__(self, source):
pass

@classmethod
@provide_session
Expand Down
1 change: 0 additions & 1 deletion airflow/hooks/webhdfs_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class WebHDFSHook(BaseHook):
"""

def __init__(self, webhdfs_conn_id='webhdfs_default', proxy_user=None):
super().__init__(webhdfs_conn_id)
self.webhdfs_conn_id = webhdfs_conn_id
self.proxy_user = proxy_user

Expand Down

0 comments on commit 053f522

Please sign in to comment.