Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipfian distribution option to vary value size for continuous ingest #276

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

DomGarguilo
Copy link
Member

This PR adds an optional component to the value created in continuous ingest. A random portion of data will be inserted into the value whose size is determined via a zipfian distribution.

The motivation behind this is to add optional variance to the sizes of values that are inserted via continuous ingest. Zipfian distribution was selected since it tends to correspond to the distribution of real-world events.

Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried running this, but I'm fine with merging this sooner rather than wait, if you want to get it in to test with it. It can always be improved later. The testing repo is really for us anyway, not something we release.

@ctubbsii ctubbsii changed the base branch from main to 2.1 December 10, 2024 20:26
@ctubbsii
Copy link
Member

@DomGarguilo what's the status of this? It seems ready to merge. If you merge it to 2.1, you should subsequently merge it to 3.1 and then merge 3.1 to main.

@DomGarguilo
Copy link
Member Author

@DomGarguilo what's the status of this? It seems ready to merge. If you merge it to 2.1, you should subsequently merge it to 3.1 and then merge 3.1 to main.

Yep, ready to merge. Thanks for switching the base branch. I'll merge it in and merge it up as suggested.

@DomGarguilo DomGarguilo merged commit e9e5e7a into apache:2.1 Dec 10, 2024
1 check passed
@DomGarguilo DomGarguilo deleted the zipfianIngest branch December 10, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants