Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Rename package to k8s #497

Merged
merged 2 commits into from
Sep 21, 2017
Merged

Rename package to k8s #497

merged 2 commits into from
Sep 21, 2017

Conversation

foxish
Copy link
Member

@foxish foxish commented Sep 20, 2017

/xref #492 (comment)

cc @apache-spark-on-k8s/contributors

@foxish
Copy link
Member Author

foxish commented Sep 21, 2017

Let's merge this after the new 2.2 release.

Copy link

@mccheah mccheah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also good that the non-code references were corrected, such as the Dockerfiles.

@foxish
Copy link
Member Author

foxish commented Sep 21, 2017

On second thought, maybe we should include this in the release. It will help folks migrate to the upstream one without jumping through hoops. WDYT @mccheah @liyinan926

@liyinan926
Copy link
Member

@foxish I think this should go into the new release. It's better doing it earlier than later. It makes the upcoming upstreaming PRs easier to go by.

@foxish
Copy link
Member Author

foxish commented Sep 21, 2017

Agreed. It's low-risk since the failures would have been fairly obvious.

@foxish foxish merged commit 7477cbe into branch-2.2-kubernetes Sep 21, 2017
@foxish foxish deleted the rename-package branch September 21, 2017 21:57
@ifilonenko
Copy link
Member

ifilonenko commented Sep 25, 2017

@varunkatta @ssuchter The Jenkins environment needs to be updated since the commands had a wildcard on deploy.kubernetes.* which has been changed to deploy.k8s.*

@foxish
Copy link
Member Author

foxish commented Sep 25, 2017

Good catch @ifilonenko! We should do this asap. Manually verifying that integration tests are okay.

@ssuchter
Copy link
Member

ssuchter commented Sep 25, 2017 via email

@foxish
Copy link
Member Author

foxish commented Sep 25, 2017

The integration tests run:

./build/mvn -B -Dmaven.repo.local=/home/jenkins/.m2/pr_intg_test_repo clean integration-test -Pkubernetes -Pkubernetes-integration-tests -pl resource-managers/kubernetes/integration-tests -am -Dtest=none -DwildcardSuites=org.apache.spark.deploy.kubernetes.integrationtest.KubernetesSuite

We need to change the last argument to -DwildcardSuites=org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.
Can you create a login/pass for me and Ilan? Then we could probably do this directly.

@ssuchter
Copy link
Member

ssuchter commented Sep 25, 2017 via email

ifilonenko pushed a commit to ifilonenko/spark that referenced this pull request Feb 26, 2019
* Rename package to k8s

* Rename string constants
puneetloya pushed a commit to puneetloya/spark that referenced this pull request Mar 11, 2019
* Rename package to k8s

* Rename string constants
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants