Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of api.get_zone_status_stream not return after timeout #25

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix the issue of api.get_zone_status_stream not return after timeout #25

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a19a88c
Fix the issue of api.get_zone_status_stream not return after timeout
stephenli2000 Dec 22, 2021
0146c4f
Made the get_zone_status_stream api return an empty dict when to keep…
leefrank9527 Dec 23, 2021
bb97256
Clean up/revert the change introduced by a19a88
stephenli2000 Dec 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion brainframe/api/stubs/zone_statuses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
import time
from typing import Dict, Generator

import requests
Expand Down Expand Up @@ -51,6 +52,7 @@ def zone_status_iterator():
resp = self._get(req, timeout=timeout)

packets = resp.iter_lines(delimiter=b"\r\n")
timeout_start = time.time()
velovix marked this conversation as resolved.
Show resolved Hide resolved
while True:
try:
packet = next(packets)
Expand All @@ -66,7 +68,10 @@ def zone_status_iterator():
raise bf_errors.ServerNotReadyError(message)

if packet == b'':
continue
if time.time() < timeout_start + timeout:
continue
else:
break

# Parse the line
zone_statuses_dict = json.loads(packet)
Expand Down