Bump platform tools version #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
approved these changes
Jul 19, 2024
|
Before merging, I'll investigate why the CI is failing. |
LucasSte
force-pushed
the
update-42
branch
2 times, most recently
from
20f101e
to
98adf23
Compare
LucasSte
force-pushed
the
update-42
branch
2 times, most recently
from
b58edc1
to
ff6823f
Compare
|
@dmakarov I included other changes in this PR to make the CI pass. Would you like to check it again before merging? The default GitHub runner for MacOS is now an ARM computer, not an x86. |
dmakarov
approved these changes
Jul 23, 2024
.github/workflows/main.yml
Outdated
| @@ -95,11 +95,11 @@ jobs: | |||
| - name: Download macOS tarball | |||
| uses: actions/download-artifact@v3 | |||
| with: | |||
| name: platform-tools-osx-x86_64.tar.bz2 | |||
| name: platform-tools-osx-aarch.tar.bz2 | |||
There was a problem hiding this comment.
shouldn't this be aarch64?
There was a problem hiding this comment.
I missed that one. Thanks for catching.
dmakarov
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.