[SOL] Better sBPFv1 sign extension #103
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using "add32 reg, 0" for sign extension is more efficient than using "lsh reg, 32; arsh reg 32".
LucasSte
changed the title
ripatel-fd
commented
Jul 4, 2024
| @@ -185,6 +185,69 @@ bool SBFMIPeephole::eliminateZExtSeq() { | |||
| } | |||
|
|
|||
| // Eliminate the 32-bit to 64-bit zero extension sequence when possible. | |||
There was a problem hiding this comment.
This is in the wrong place - This deals with sign extension, not zero extension
|
@LucasSte Should I make the commits say "SOL" instead of "SBF"? |
Yes, this is what we've been using in the history. |
|
Are you still interested in getting this PR merged? I have updated compiler to LLVM 18, so would you mind opening the PR again the |
Yes, I'll rebase, thanks for letting me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "add32 reg, 0" for sign extension is more efficient than using "lsh reg, 32; arsh reg 32".
_631ee818051efc6985667197-LLVM sBPF sign-extend optimzation-040724-143334.pdf