refactor: reorder PohRecorder methods #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
refactor/poh-reorder-fns
branch
from
d295e3d to
7f8b4ab
Compare
bw-solana
previously approved these changes
Feb 12, 2025
poh/src/poh_recorder.rs
Outdated
| @@ -810,6 +999,31 @@ impl PohRecorder { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn reset_poh(&mut self, reset_bank: Arc<Bank>, reset_start_bank: bool) { | |||
There was a problem hiding this comment.
I'm wondering if reset_poh, should be up near clear_bank
Similarly, set_bank and flush_cache could go up near these friends.
There was a problem hiding this comment.
Yeah good call, moved those too
jstarry
force-pushed
the
refactor/poh-reorder-fns
branch
from
70fba16 to
0a05b1a
Compare
bw-solana
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PohRecordermethods and constructors are in a weird order and make it hard to navigate the codeSummary of Changes
fn reset,fn record, andfn tickFixes #