Replace solana_program::stake with solana_stake_interface #4664
+152
−2,769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firedancer team maintains a line-for-line reimplementation of the |
kevinheavey
force-pushed
the
stake-interface-replace
branch
from
04cf92a to
2065824
Compare
kevinheavey
changed the title
joncinque
reviewed
Jan 31, 2025
Comment on lines
+13
to
+16
| solana-account-info= { path = "../../../../../sdk/account-info", version = "=2.2.0" } | ||
| solana-program-entrypoint = { path = "../../../../../sdk/program-entrypoint", version = "=2.2.0" } | ||
| solana-program-error= { path = "../../../../../sdk/program-error", version = "=2.2.0" } | ||
| solana-pubkey = { path = "../../../../../sdk/pubkey", version = "=2.2.0" } |
There was a problem hiding this comment.
Nice, this is so much simpler, sorry I didn't think of it earlier.
genesis/Cargo.toml
Outdated
| @@ -34,6 +34,7 @@ tempfile = { workspace = true } | |||
|
|
|||
| [dev-dependencies] | |||
| solana-runtime = { workspace = true, features = ["dev-context-only-utils"] } | |||
| solana-stake-interface = { workspace = true, features = ["borsh"] } | |||
There was a problem hiding this comment.
Sorry, it's not clear from this PR or the code in genesis -- why is this dependency needed?
| "dep:solana-frozen-abi", | ||
| "dep:solana-frozen-abi-macro", | ||
| "solana-stake-interface/frozen-abi" | ||
| ] | ||
| serde = [ |
There was a problem hiding this comment.
Can we enable the serde feature on solana-stake-interface if the serde feature on this crate is enabled?
kevinheavey
force-pushed
the
stake-interface-replace
branch
from
7c49055 to
be32f23
Compare
LucasSte
approved these changes
Jan 31, 2025
kevinheavey
added
the
automerge
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4529
Changes:
solana-stake-interfaceto replace what's insolana_program::stake