Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests that need to shut down transaction status service. #4654

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

fkouteib
Copy link

Unify the wind down of transaction status service across different unit tests to ensure more consistency, and make sure all tx statuses are processed before the verification step of each test.

This change was forked from agave PR #4032 (specifically these comments here and here for context).

Copy link

mergify bot commented Jan 28, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @fkouteib.

@fkouteib
Copy link
Author

@steviez I tried to make the new function dcou, but ran into an issue with 'features' not allowed in 'svm/examples' toml file, which would be needed in addition to adding solana-rpc as a dev dependency. So I left it out for now.

@steviez
Copy link

steviez commented Jan 28, 2025

@steviez I tried to make the new function dcou, but ran into an issue with 'features' not allowed in 'svm/examples' toml file, which would be needed in addition to adding solana-rpc as a dev dependency. So I left it out for now.

That is surprising to me. I don't see solana-rpc as a dependency listed here:
https://github.com/anza-xyz/agave/blob/master/svm/examples/Cargo.toml

It looks like you force-pushed and blew away your old commits so I can't see what you had. Did you see that failure reported in CI or during local build ?

@fkouteib fkouteib requested a review from bw-solana January 28, 2025 06:15
@fkouteib fkouteib requested a review from steviez January 28, 2025 07:32
@fkouteib
Copy link
Author

Did you see that failure reported in CI or during local build ?

feature not allowed was on a local build. But it appears that was more of a skill issue on my part...I think we are good to go with the latest patch for making it dcou (asuming it clears CI). Thx for quick review and response.

Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits

rpc/src/rpc.rs Outdated Show resolved Hide resolved
rpc/src/transaction_status_service.rs Outdated Show resolved Hide resolved
rpc/src/transaction_status_service.rs Outdated Show resolved Hide resolved
rpc/src/transaction_status_service.rs Show resolved Hide resolved
Copy link

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fkouteib fkouteib merged commit 0d68275 into anza-xyz:master Jan 29, 2025
58 checks passed
@fkouteib fkouteib deleted the tss-tests-cleanup branch January 29, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants