turbine: Adjust reference tick calculation #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
changed the title
bw-solana
previously approved these changes
Jan 27, 2025
behzadnouri
reviewed
Jan 27, 2025
|
Can we remove the https://github.com/anza-xyz/agave/blob/f5d6ebcfb/turbine/src/broadcast_stage/standard_broadcast_run.rs#L276 and this line: |
bw-solana
previously approved these changes
Jan 27, 2025
behzadnouri
reviewed
Jan 27, 2025
The current reference tick calculation results in the reference tick being recorded as 0 when a Bank has reached max tick_height. The reference tick is used to determine if/when shreds should be repaired, so adjust the calculation to saturate at bank.ticks_per_slot() - 1 instead.
steviez
force-pushed
the
broadcast_saturate_ref_tick
branch
from
1d61261 to
624ad06
Compare
No need to apply the mask in turbine code as the underlying code will do it for us
steviez
force-pushed
the
broadcast_saturate_ref_tick
branch
from
624ad06 to
55ed445
Compare
|
I know you both gave me ship-its, but I decided to push the cleanup into a separate PR (#4653) for the sake of keeping the diff in this PR as small as possible. I also force pushed to cleanup commit history + rebase to tip of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current reference tick calculation results in the reference tick being recorded as 0 when a Bank has reached max tick height
Summary of Changes
Adjust the calculation to saturate at
bank.ticks_per_slot() - 1, which coincides with the max value of 63 that fit in the 6 bits allocated forreference_tickin the shred header.I sampled a random block (
313491481) from MNB and plotted reference tick vs. shred index to show the issue: