CI: Disable downstream SPL jobs #4489
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The downstream SPL jobs are failing CI due to missing documentation on a public module for the tests. This is likely due to the upgrade to Rust 1.84, and these modules need to be labeled as `pub(crate)`. #### Summary of changes To unblock CI, just disable the tests.
pgarg66
approved these changes
Jan 16, 2025
|
Merging early to unblock CI -- all downstream SPL jobs were correctly skipped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The downstream SPL jobs are failing CI due to missing documentation on a public module for the tests. This is likely due to the upgrade to Rust 1.84, and these modules need to be labeled as
pub(crate).Summary of changes
To unblock CI, just disable the tests.