Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove almost all solana-sdk usage from solana-stake-program #4447

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

kevinheavey
Copy link

Problem

All solana-sdk usage can be removed from solana-stake-program, except for the genesis_config module, which is getting pulled out in #4076

Summary of Changes

Remove what can be removed

Copy link

mergify bot commented Jan 14, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise look good, just one question for clarification.

programs/stake/Cargo.toml Show resolved Hide resolved
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevinheavey kevinheavey added the automerge automerge Merge this Pull Request automatically once CI passes label Jan 14, 2025
@mergify mergify bot merged commit d3dc3d0 into anza-xyz:master Jan 14, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants