v2.1: PrioritizationFeeCache: make update() never sleep on the sender channel (backport of #3813) #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
why backport: this is a fairly trivial change that's an easy win on the replay side, and especially if we increase CUs in 2.1 this saves even more time |
bw-solana
approved these changes
Nov 27, 2024
bw-solana
force-pushed
the
mergify/bp/v2.1/pr-3813
branch
from
2a2121b to
6ff8908
Compare
…el (#3813) Avoid update() callers having to notify the service_loop() thread by doing an explicit sleep instead of sleeping on channel.recv() when the channel is empty. This avoids the case in which multiple replay/banking threads call update() at the same time and end up... sleeping themselves acquiring the mutex to notify the receiver. (cherry picked from commit 53af223)
alessandrod
force-pushed
the
mergify/bp/v2.1/pr-3813
branch
from
6ff8908 to
99da6c5
Compare
steviez
approved these changes
Dec 6, 2024
KirillLykov
pushed a commit
that referenced
this pull request
Dec 9, 2024
… channel (backport of #3813) (#3818) PrioritizationFeeCache: make update() never sleep on the sender channel (#3813) Avoid update() callers having to notify the service_loop() thread by doing an explicit sleep instead of sleeping on channel.recv() when the channel is empty. This avoids the case in which multiple replay/banking threads call update() at the same time and end up... sleeping themselves acquiring the mutex to notify the receiver. (cherry picked from commit 53af223) Co-authored-by: Alessandro Decina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid update() callers having to notify the service_loop() thread by doing an explicit sleep instead of sleeping on channel.recv() when the channel is empty. This avoids the case in which multiple replay/banking threads call update() at the same time and end up... sleeping themselves acquiring the mutex to notify the receiver.
Before and after
This is an automatic backport of pull request #3813 done by [Mergify](https://mergify.com).