Extract feature-set crate #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this PR represents a change to the public RPC API:
Thank you for keeping the RPC clients in sync with the server API @kevinheavey. |
kevinheavey
force-pushed
the
extract-feature-set
branch
4 times, most recently
from
55d2f0b to
17fa98b
Compare
kevinheavey
force-pushed
the
extract-feature-set
branch
4 times, most recently
from
7c014d6 to
4ef520a
Compare
kevinheavey
force-pushed
the
extract-feature-set
branch
from
e154f71 to
e4ca26e
Compare
|
The Firedancer team maintains a line-for-line reimplementation of the |
kevinheavey
force-pushed
the
extract-feature-set
branch
from
d35364e to
8b70ede
Compare
kevinheavey
force-pushed
the
extract-feature-set
branch
2 times, most recently
from
e02b542 to
075967f
Compare
joncinque
reviewed
Sep 9, 2024
| clock::Slot, | ||
| epoch_schedule::EpochSchedule, |
There was a problem hiding this comment.
Once EpochSchedule gets moved out of solana_program, this crate could depend only on pubkey, hash, clock, and that 🥳
kevinheavey
force-pushed
the
extract-feature-set
branch
from
4c901a2 to
d2a356d
Compare
|
all green! |
kevinheavey
added
the
automerge
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* extract feature-set crate * update feature_set dependents * re-export with deprecation notice * fix path after rebase * fmt * fmt after rebase * fixes after rebase * unused import * fix import * unused import * post-rebase fixes * fix path * missing frozen-abi support * update lock file * use workspace lints * fix paths * fix import * remove unused import * remove unused deps * consolidate imports * add back dep (not unused after all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana_sdk::feature_setblocks a lot of things from being pulled out of the sdk, includingsdk::transactionSummary of Changes