Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lab 04 numeronym #518

Closed
wants to merge 2 commits into from
Closed

Implement lab 04 numeronym #518

wants to merge 2 commits into from

Conversation

undrewb
Copy link
Collaborator

@undrewb undrewb commented Jun 30, 2019 •
edited by juliaogris
Loading

Implement functions
Implement tests
Fixes #517

Review of colleague's PR #515

Changes proposed in this PR:

  • Implement lab 4 of go-course
  • Decompose into numeronym and numeronyms for testing.
  • Don't consider non-ascii or special chars ( like _ or white space ) different to regular chars.
    Implement testing.

Implement lab 04 numeronym
b845b1e 
Implement functions
Implement tests
@codecov
Copy link

codecov bot commented Jun 30, 2019 •
edited
Loading

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #518   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          72     73    +1     
  Lines        1262   1275   +13     
=====================================
+ Hits         1262   1275   +13
Impacted Files Coverage Δ
04_numeronym/undrewb/main.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3bd20f...0b9fb92. Read the comment docs.

sirigithub
sirigithub previously requested changes Jul 7, 2019
View reviewed changes
04_numeronym/undrewb/main.go Outdated Show resolved Hide resolved
04_numeronym/undrewb/main_test.go Show resolved Hide resolved
@sirigithub sirigithub mentioned this pull request Jul 7, 2019
Merged
Implement unicode handling
0b9fb92 
Add test cases for unicode
Modify numeronym to use rune length not byte len

Add test cases for unicode
@undrewb undrewb requested a review from samuong as a code owner August 21, 2019 09:42
anzboi
anzboi approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@anzboi anzboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work

@anzboi
Copy link
Member

anzboi commented Aug 22, 2019

Apologies for taking so long to get to this.

@juliaogris
Copy link
Contributor

The go-course is now closed. Thank you very much for participating.

@juliaogris juliaogris closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anzboi anzboi anzboi approved these changes

@anzdaddy anzdaddy Awaiting requested review from anzdaddy anzdaddy is a code owner

@camscale camscale Awaiting requested review from camscale

@joshcarp joshcarp Awaiting requested review from joshcarp

@juliaogris juliaogris Awaiting requested review from juliaogris

@linuxmonk linuxmonk Awaiting requested review from linuxmonk

@pentaphobe pentaphobe Awaiting requested review from pentaphobe pentaphobe is a code owner

@rokane rokane Awaiting requested review from rokane rokane is a code owner

@samuong samuong Awaiting requested review from samuong samuong is a code owner

@sirigithub sirigithub Awaiting requested review from sirigithub

Assignees
No one assigned
Labels
lab4 Merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lab 4 - numeronym by undrewb
4 participants
@undrewb @anzboi @juliaogris @sirigithub