Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev tools upgrade #12

Merged
merged 5 commits into from
Mar 22, 2022
Merged

Dev tools upgrade #12

merged 5 commits into from
Mar 22, 2022

Conversation

palkan
Copy link
Member

@palkan palkan commented Mar 22, 2022 •
edited
Loading

What is the purpose of this pull request?

DX housekeeping.

Changes overview

  • Upgrade Docker for Dev configuration (based on the recent ruby-on-whales updates)
  • Dropped Pronto and added RuboCop TODO
  • Added bin/rubocop
  • Moved RuboCop configs to .rubocop/
  • Minor system tests fixes
  • Fixed GraphQL specs
  • Turned on transactional fixtures
  • Added custom RuboCop tags for RSpec files

Checklist

  • I've fixed all review comments

@palkan palkan requested a review from fargelus March 22, 2022 07:26
palkan
palkan commented Mar 22, 2022
View reviewed changes
dip.yml Show resolved Hide resolved
@palkan palkan force-pushed the chore/upgrade-docker-dev-rubocop branch from 8b5cd70 to 0d7bae4 Compare March 22, 2022 07:30
@palkan palkan force-pushed the chore/upgrade-docker-dev-rubocop branch from 0d7bae4 to 191134f Compare March 22, 2022 07:32
@palkan palkan requested review from skryukov and removed request for fargelus March 22, 2022 07:33
palkan
palkan commented Mar 22, 2022
View reviewed changes
Gemfile.lock Show resolved Hide resolved
@palkan palkan force-pushed the chore/upgrade-docker-dev-rubocop branch from 53fa398 to de9190e Compare March 22, 2022 12:33
@palkan palkan merged commit b8325b6 into main Mar 22, 2022
@palkan palkan deleted the chore/upgrade-docker-dev-rubocop branch March 22, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fargelus fargelus fargelus approved these changes

@skryukov skryukov Awaiting requested review from skryukov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palkan @fargelus