-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added monthly pageviews and users to analytics sheets (#3536) #3552
feat: added monthly pageviews and users to analytics sheets (#3536) #3552
Conversation
jpaten
commented
Feb 5, 2025
- Added pageviews and total users per month to the analytics sheets, including a chart
- View example sheet here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpaten Hmm, something I failed to consider when reviewing the package update: the old graph-creation code was designed to be run specifically with the end time being the month after the month being reported on, which is why the dataframe is sliced starting at -2, to cut off the most recent month. I think the package will need to be updated so that the df_processor
used in get_change_over_time_df
slices [::-1]
instead of [-2::-1]
, so that it just reverses the rows rather than cutting off the final month (e.g. December is currently missing from the example sheet)
Whoops, thanks for catching that @hunterckx! I've made a pr to make that change (I could also make it to cut off the last date in |
Hi @hunterckx! I updated to the new package version. An example sheet is here |
Caught a couple of extra changes but should be good now, here's a new example sheet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!