Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added monthly pageviews and users to analytics sheets (#3536) #3552

Merged

Conversation

jpaten
Copy link
Collaborator

@jpaten jpaten commented Feb 5, 2025

  • Added pageviews and total users per month to the analytics sheets, including a chart
  • View example sheet here

@jpaten jpaten requested a review from hunterckx February 5, 2025 01:34
@jpaten jpaten linked an issue Feb 5, 2025 that may be closed by this pull request
Copy link
Collaborator

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpaten Hmm, something I failed to consider when reviewing the package update: the old graph-creation code was designed to be run specifically with the end time being the month after the month being reported on, which is why the dataframe is sliced starting at -2, to cut off the most recent month. I think the package will need to be updated so that the df_processor used in get_change_over_time_df slices [::-1] instead of [-2::-1], so that it just reverses the rows rather than cutting off the final month (e.g. December is currently missing from the example sheet)

@jpaten
Copy link
Collaborator Author

jpaten commented Feb 5, 2025

Whoops, thanks for catching that @hunterckx! I've made a pr to make that change (I could also make it to cut off the last date in get_flat_data_df, so all intervals are half-open, but this felt simpler DataBiosphere/data-browser#4366

@jpaten jpaten marked this pull request as draft February 5, 2025 23:53
@jpaten jpaten marked this pull request as ready for review February 7, 2025 17:16
@jpaten
Copy link
Collaborator Author

jpaten commented Feb 7, 2025

Hi @hunterckx! I updated to the new package version. An example sheet is here

@jpaten
Copy link
Collaborator Author

jpaten commented Feb 7, 2025

Caught a couple of extra changes but should be good now, here's a new example sheet

@jpaten jpaten requested a review from hunterckx February 7, 2025 23:46
Copy link
Collaborator

@hunterckx hunterckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hunterckx hunterckx merged commit 56fc8d1 into main Feb 8, 2025
4 checks passed
@hunterckx hunterckx deleted the jonah/3536-analytics-sheets-monthly-users-and-page-views branch February 8, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly users and page views
2 participants