WIP: Add new lemma stating all reconciles will eventually satisfy a set of requirements #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
This proves more invariants in VReplicaSet except those assigned to @Catoverflow, and those whose proofs will likely depend on #580. --------- Signed-off-by: Cody Rivera <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
This introduces a `reconcile_id` field for each `OngoingReconcile` for a controller. When a reconcile is started, the allocator is queried for a new `reconcile_id`, and then is incremented. The `reconcile_id_allocator` is unique to each controller installed in the cluster, but is preserved across controller restarts for easier reasoning. This addition slows down the proof for `lemma_from_after_send_create_pod_req_to_receive_ok_resp`, where I had to increase `rlimit`. This is in service of a proof for the lemma proposed in #580 . --------- Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
codyjrivera
force-pushed
the
cody/add-leads-to-every-reconcile-satisfies
branch
from
17a6f0f to
1b833dc
Compare
Signed-off-by: Cody Rivera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lemma shows that if the spec ensures every newly started reconcile for a given controller_id satisfies some requirements (including termination of reconciles), the system will eventually reaches a state where all ongoing reconciles of that controller_id satisfy those requirements.