Prove ReplicaSet invariants, Convert Model from usize to unbounded Nats
#575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
codyjrivera
commented
Jan 16, 2025
Closed
codyjrivera
changed the title
usize to unbounded Natsusize to unbounded Nats
| @@ -97,7 +97,7 @@ pub open spec fn reconcile_core(v_replica_set: VReplicaSetView, resp_o: Option<R | |||
| obj: pod.marshal(), | |||
| }); | |||
| let state_prime = VReplicaSetReconcileState { | |||
| reconcile_step: VReplicaSetReconcileStep::AfterCreatePod((diff - 1) as usize), | |||
| reconcile_step: VReplicaSetRecStepView::AfterCreatePod(abs(diff - 1)), | |||
There was a problem hiding this comment.
Why do we need abs (which should be a no-op here)? Is it to make sure the result is still a nat since there is subtraction here?
There was a problem hiding this comment.
The compiler complains if the expression is left as-is without a cast/operation. If you'd prefer as nat, I can do that change.
There was a problem hiding this comment.
Yes let's use as nat, which looks more natural
src/v2/controllers/vreplicaset_controller/proof/helper_invariants/predicate.rs
Outdated
Show resolved
Hide resolved
src/v2/controllers/vreplicaset_controller/proof/liveness/resource_match.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Rivera <[email protected]>
codyjrivera
force-pushed
the
cody/convert-to-unb-integers
branch
from
822dbc4 to
3dc70cd
Compare
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
| @@ -1,14 +1,14 @@ | |||
| use crate::kubernetes_api_objects::spec::prelude::*; | |||
| use crate::reconciler::spec::{io::*, reconciler::*}; | |||
| use crate::vreplicaset_controller::trusted::{spec_types::*, step::*}; | |||
| use vstd::prelude::*; | |||
| use vstd::{prelude::*, math::abs}; | |||
There was a problem hiding this comment.
@codyjrivera Can you also remove this import of abs? After that you can merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prove several additional invariants for VReplicaSet; convert reconcile step data structure to unbounded integers.