[WIP] feat: 优化组件层-明细表切换到透视表时的布局效果 #2950
Open
+29
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +70 B (+0.02%) Total Size: 336 kB
ℹ️ View Unchanged
|
lijinke666
commented
Oct 29, 2024
| @@ -62,6 +62,14 @@ export class PivotFacet extends FrozenFacet { | |||
| return this.spreadsheet.options.colCell?.(...args) || new ColCell(...args); | |||
| } | |||
|
|
|||
| public render() { | |||
| if (isEmpty(this.spreadsheet.dataCfg?.fields?.values)) { | |||
There was a problem hiding this comment.
values 为空时不重新构建 layout, 避免 react 组件层在明细切透视时闪烁
lijinke666
changed the title
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
lijinke666
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge