V5 feat/cubic edge,cubic horizon edge,cubic vertical edge #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update jest.config.js for using `@kayahr/jest-electron-runner` * update rollup.config.js for using `@rollup/plugin-terser`
chore: add integration test chore: add unit test(but there have several tests TODO )
*feat: v5-cubic-horizon-edge *chore: test/unit/v5-cubic-horizon-edge *chore: test/integration/v5-cubic-horizon-edge
*feat: v5-cubic-horizon-edge *chore: test/unit/v5-cubic-horizon-edge *chore: test/integration/v5-cubic-horizon-edge fix: curve bug
Yanyan-Wang
reviewed
Jun 25, 2023
|
感谢 PR ～～ 感觉问题不大了，有两个冲突可以 rebase 一下 v5 分支解决一下。另外是否能贴一些效果截图 |
*chore: change test svg link *fix: fix the cubic offset
Yanyan-Wang
reviewed
Jun 25, 2023
Yanyan-Wang
reviewed
Jun 25, 2023
packages/g6/tests/intergration/item/edge/cubic-vertical-edge.ts
Outdated
Show resolved
Hide resolved
xiaoiver
reviewed
Jun 26, 2023
xiaoiver
reviewed
Jun 26, 2023
* fix: support position config:'topRight' * add demo to reproduce bug
* update: update demo for bug reproduce * fix: fix the bug
* feat: add RectNode * add: add rect test demo * add: add rect test demo * update: update RectNode with less override * update: remove 'console.log' * update: remove comment * update: remove cn comment * add: add rect-spec.ts for unit test --------- Co-authored-by: Yanyan Wang <[email protected]>
* fix: implement onZoom as empty function for 3d node * chore: refine * chore: lint
* add: add a test demo * feat: add quadratic * add: add unit test demo * fix: add seItemState(selected、active、highlight、inactive、disable) test into spec.
chore: add integration test chore: add unit test(but there have several tests TODO )
*feat: v5-cubic-horizon-edge *chore: test/unit/v5-cubic-horizon-edge *chore: test/integration/v5-cubic-horizon-edge
*feat: v5-cubic-horizon-edge *chore: test/unit/v5-cubic-horizon-edge *chore: test/integration/v5-cubic-horizon-edge fix: curve bug
*chore: use relative import path *chore: delete unused imports *fix: fix the rebase imports
Yanyan-Wang
approved these changes
Jun 26, 2023
|
合并啦～ |
liaodalin19903
deleted the
v5-feat/cubic-edge,cubic-horizon-edge,cubic-vertical-edge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change
Test snapshots