fix: unexpected element clear (#6710)

* fix: unexpected element clear * chore: update version
antvis · Jan 9, 2025 · e22f7b7 · e22f7b7
1 parent 8c20ec8
commit e22f7b7
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 80 deletions.
diff --git a/packages/g6-extension-3d/package.json b/packages/g6-extension-3d/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g6-extension-3d",
-  "version": "0.1.15",
+  "version": "0.1.16",
   "description": "3D extension for G6",
   "keywords": [
     "antv",

diff --git a/packages/g6-extension-react/package.json b/packages/g6-extension-react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g6-extension-react",
-  "version": "0.1.16",
+  "version": "0.1.17",
   "description": "Using React Component to Define Your G6 Graph Node",
   "keywords": [
     "antv",

diff --git a/packages/g6-ssr/package.json b/packages/g6-ssr/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g6-ssr",
-  "version": "0.0.10",
+  "version": "0.0.11",
   "description": "Support SSR for G6",
   "keywords": [
     "antv",

diff --git a/packages/g6/__tests__/bugs/graph-draw-after-clear.spec.ts b/packages/g6/__tests__/bugs/graph-draw-after-clear.spec.ts
@@ -8,6 +8,8 @@ it('graph draw after clear', async () => {
 
   await graph.clear();
 
+  await expect(graph).toMatchSnapshot(__filename, 'blank');
+
   await sleep(200);
 
   graph.addData(data);

diff --git a/packages/g6/__tests__/snapshots/bugs/graph-draw-after-clear/blank.svg b/packages/g6/__tests__/snapshots/bugs/graph-draw-after-clear/blank.svg
diff --git a/packages/g6/__tests__/snapshots/bugs/graph-draw-after-clear/default.svg b/packages/g6/__tests__/snapshots/bugs/graph-draw-after-clear/default.svg
diff --git a/packages/g6/package.json b/packages/g6/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g6",
-  "version": "5.0.41",
+  "version": "5.0.42",
   "description": "A Graph Visualization Framework in JavaScript",
   "keywords": [
     "antv",

diff --git a/packages/g6/src/runtime/element.ts b/packages/g6/src/runtime/element.ts
@@ -53,7 +53,11 @@ export class ElementController {
   }
 
   public init() {
-    if (!this.container) {
+    this.initContainer();
+  }
+
+  private initContainer() {
+    if (!this.container || this.container.destroyed) {
       const { canvas } = this.context;
       this.container = canvas.appendChild(new Group({ className: 'elements' }));
     }
@@ -854,7 +858,8 @@ export class ElementController {
    * <en/> clear all elements
    */
   public clear() {
-    this.container.children.forEach((element) => element.destroy());
+    this.container.destroy();
+    this.initContainer();
     this.elementMap = {};
     this.shapeTypeMap = {};
     this.defaultStyle = {};

diff --git a/packages/g6/src/version.ts b/packages/g6/src/version.ts
@@ -1 +1 @@
-export const version = '5.0.41';
+export const version = '5.0.42';
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const version = '5.0.41';
		export const version = '5.0.42';