fix: multi-line text wrapping exception #1887
Merged
+66
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#1833
💡 Background and solution
see #1876
When calculating the line break position, a more accurate result is obtained by adopting a strategy of character-by-character measurement cache combined with whole-text measurement. Among them, when the whole-text measurement strategy is used to approximate the optimal value character by character near the threshold, it is not considered that when a single character cannot be displayed, the character-by-character correction will cause the starting character position of each line to return to the beginning of the whole text, resulting in abnormal display after multiple lines of text are wrapped.
In order to deal with this edge case, the index of the last character of each line should be recorded, and when calculating the line break position of the current line, the starting character index of the current line should be used as the boundary condition.
Before
After
📝 Changelog
☑️ Self Check before Merge