refactor: set enableMassiveParsedStyleAssignOptimization to default

antvis · Nov 25, 2024 · ccad436 · ccad436
1 parent 6f347e4
commit ccad436
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 16 deletions.
diff --git a/__tests__/demos/bugfix/group-with-stroke.ts b/__tests__/demos/bugfix/group-with-stroke.ts
@@ -3,8 +3,6 @@ import { Group, Path, Rect, runtime } from '@antv/g';
 export async function group_with_stroke(context) {
   const { canvas } = context;
 
-  runtime.enableMassiveParsedStyleAssignOptimization = true;
-
   await canvas.ready;
 
   const group = new Group({

diff --git a/__tests__/demos/perf/massive-attrs.ts b/__tests__/demos/perf/massive-attrs.ts
@@ -3,8 +3,6 @@ import { Rect, runtime } from '@antv/g';
 export async function massiveAttrs(context) {
   const { canvas, gui } = context;
 
-  runtime.enableMassiveParsedStyleAssignOptimization = true;
-
   await canvas.ready;
 
   console.time('massiveAttrs');

diff --git a/packages/g-lite/src/css/StyleValueRegistry.ts b/packages/g-lite/src/css/StyleValueRegistry.ts
@@ -2,7 +2,7 @@ import { isNil, isUndefined } from '@antv/util';
 import { vec3 } from 'gl-matrix';
 import type { DisplayObject } from '../display-objects';
 import { EMPTY_PARSED_PATH } from '../display-objects/constants';
-import { runtime, type GlobalRuntime } from '../global-runtime';
+import type { GlobalRuntime } from '../global-runtime';
 import { GeometryAABBUpdater } from '../services';
 import { AABB } from '../shapes';
 import type { BaseStyleProps, Tuple3Number } from '../types';
@@ -1007,11 +1007,6 @@ function assignParsedStyle(
   object: DisplayObject,
   attributes: Record<string, any>,
 ) {
-  if (!runtime.enableMassiveParsedStyleAssignOptimization) {
-    Object.assign(object.parsedStyle, attributes);
-    return;
-  }
-
   const list = getParsedStyleListOf(object);
   for (const key in attributes) {
     if (list.has(key)) {

diff --git a/packages/g-lite/src/global-runtime.ts b/packages/g-lite/src/global-runtime.ts
@@ -73,12 +73,6 @@ export interface GlobalRuntime {
   enableStyleSyntax: boolean;
 
   enableSizeAttenuation: boolean;
-
-  /**
-   * Only clone properties that are listed in the `PARSED_STYLE_LIST` of the display object.
-   * default false
-   */
-  enableMassiveParsedStyleAssignOptimization?: boolean;
 }
 
 /**